SA1520 consistent use of opening and closing braces on if statements#7198
Merged
Conversation
sharwell
approved these changes
Jan 2, 2022
sharwell
approved these changes
Jan 2, 2022
Contributor
sharwell
left a comment
sharwell
left a comment
There was a problem hiding this comment.
💡 Consider updating the .globalconfig to increase the severity of SA1520 to warning. Also note that you can achieve similar results using built-in code analysis rule IDE0011:
# IDE0011: Add braces
csharp_prefer_braces = when_multiline:warning
dotnet_diagnostic.IDE0011.severity = warning
Contributor
Author
If #7192 is merged first, then we can enable the rule/s in the .globalconfig |
Forgind
approved these changes
Jan 3, 2022
Contributor
Forgind
left a comment
Forgind
left a comment
There was a problem hiding this comment.
Consistency is good, but having unnecessary curly braces always feels wasteful to me. Little bittersweet, but I believe others were less equivocal when we talked about it.
This was referenced Jul 29, 2025
Closed
Closed
This was referenced Apr 15, 2026
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #7174
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1520.md