Emit the BuildStop ETW event at the right time#7228
Merged
Conversation
rainersigwald
approved these changes
Jan 7, 2022
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
I think BuildStart : BeginBuild :: BuildStop : EndBuild makes the most sense, yeah.
rokonec
approved these changes
Jan 10, 2022
Forgind
added
the
merge-when-branch-open
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The BuildStop event as emitted now does not really correspond to stopping the build.
Changes Made
Moved the statement to
EndBuild.Testing
Verified the event is present with PerfView.
Notes
The semantics of BuildStart / BuildStop is not super clear but if it should delimit the BuildManager session,
EndBuildappears to be the right place.