Opt into IncludeEvaluationPropertiesAndItems in NullLogger#7386
Merged
Forgind merged 1 commit intodotnet:mainfrom Feb 16, 2022
Merged
Opt into IncludeEvaluationPropertiesAndItems in NullLogger#7386Forgind merged 1 commit intodotnet:mainfrom
Forgind merged 1 commit intodotnet:mainfrom
Conversation
This keeps a build with all distribution-aware loggers from vetoing the new behavior because a logger (NullLogger) is attached that doesn't indicate that it can handle it. It trivially can, so it should!
Forgind
reviewed
Feb 14, 2022
| // external contract so can't specify that for the | ||
| // argument. | ||
|
|
||
| IEventSource4 eventSource4 = (IEventSource4)eventSource; |
Contributor
There was a problem hiding this comment.
Isn't IEventSource public? Can't someone have made their own IEventSource that doesn't implement IEventSource4?
Member
Author
There was a problem hiding this comment.
How would such a thing make it to this point? The engine instantiates the concrete implementation of IEventSource that is passed to loggers at runtime.
I originally wrote this with an as and a null check, but that seems like it would be more likely to silently fail if something very odd happened.
Forgind
added
the
merge-when-branch-open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps a build with all distribution-aware loggers from vetoing the
new behavior because a logger (NullLogger) is attached that doesn't indicate
that it can handle it. It trivially can, so it should!
Related to #1222.