Skip to content

Finalize 17.2 API surface#7510

Merged
rokonec merged 3 commits into
dotnet:mainfrom
rainersigwald:17.2-api
Apr 11, 2022
Merged

Finalize 17.2 API surface#7510
rokonec merged 3 commits into
dotnet:mainfrom
rainersigwald:17.2-api

Conversation

@rainersigwald
Copy link
Copy Markdown
Member

  1. Get-ChildItem -r src/PublicAPI.*.txt | Clear-Content
  2. Open MSBuild.sln in Visual Studio, let it settle
  3. Find a green squiggle for the analyzer and fix all in solution
  4. Get-ChildItem -r PublicAPI.Unshipped.txt | % { Move-Item -Force -Path $_ (Join-Path $_.Directory.FullName "PublicAPI.Shipped.txt") && New-Item $_ }

@rainersigwald rainersigwald added this to the VS 17.3 milestone Apr 1, 2022
@rainersigwald rainersigwald mentioned this pull request Apr 1, 2022
21 tasks
@rainersigwald rainersigwald marked this pull request as draft April 1, 2022 19:38
… $_ (Join-Path $_.Directory.FullName "PublicAPI.Shipped.txt") && New-Item $_ }
@Forgind
Copy link
Copy Markdown
Contributor

Forgind commented Apr 2, 2022

This is pointing at main. vs17.2?

Actually, both need it, right?

@rainersigwald rainersigwald marked this pull request as ready for review April 6, 2022 15:06
@rainersigwald
Copy link
Copy Markdown
Member Author

This is pointing at main. vs17.2?

Actually, both need it, right?

For 17.1, we tried doing it in the release branch but it caused some problems:

  1. Mechanical change not actually required for shipping.
  2. We had a late back-out of a public API change that caused merge conflicts

As a result we decided to try doing it only for main going forward.

@rainersigwald rainersigwald added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Apr 6, 2022
@rokonec rokonec merged commit 4778591 into dotnet:main Apr 11, 2022
@Forgind Forgind mentioned this pull request Jun 27, 2022
23 tasks
@marcpopMSFT marcpopMSFT mentioned this pull request Oct 4, 2022
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants