[WIP-FEATURE] MSBuild client#7540
Merged
Merged
Conversation
rokonec
reviewed
Apr 14, 2022
rokonec
requested changes
Apr 20, 2022
AR-May
commented
Apr 21, 2022
Forgind
reviewed
Apr 25, 2022
rokonec
approved these changes
Apr 27, 2022
Co-authored-by: Forgind <Forgind@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7374, #7373
Context
MSBuild client is a new code path that is triggered with opt-in env variable. It sends the build request for execution to the MSBuild server node. This approach avoids to do execute targets and tasks into a short-living process from CLI tools like .NET SDK and MSBuild.exe.
Changes Made
This PR implements a new MSBuild client classes able to communicate with MSBuild server node via the named pipe.
Testing
Manually tested. Automatic tests will be added in another PR.