Add doc for InvariantGlobalization property#8543
Conversation
|
|
||
| <xs:element name="InvariantGlobalization" type="msb:boolean" substitutionGroup="msb:Property"> | ||
| <xs:annotation> | ||
| <xs:documentation><!-- _locID_text="InvariantGlobalization" _locComment="" -->Indicates whether an app runs in globalization-invariant mode without access to culture-specific data and behavior.</xs:documentation> |
There was a problem hiding this comment.
| <xs:documentation><!-- _locID_text="InvariantGlobalization" _locComment="" -->Indicates whether an app runs in globalization-invariant mode without access to culture-specific data and behavior.</xs:documentation> | |
| <xs:documentation><!-- _locID_text="InvariantGlobalization" _locComment="" -->Determines whether an app runs in globalization-invariant mode without access to culture-specific data and behavior.</xs:documentation> |
imo it's clearer
There was a problem hiding this comment.
I did this to follow the pattern in other documented boolean-style properties. They all use "Indicates". The notable exception being Using_Static which starts with "Determines."
|
|
||
| <xs:element name="InvariantGlobalization" type="msb:boolean" substitutionGroup="msb:Property"> | ||
| <xs:annotation> | ||
| <xs:documentation><!-- _locID_text="InvariantGlobalization" _locComment="" -->Indicates whether an app runs in globalization-invariant mode without access to culture-specific data and behavior.</xs:documentation> |
There was a problem hiding this comment.
(nit) Do we need to specify it is a ".NET Core app" (or whatever the name of that is now days)? This property doesn't work for a .NET Framework application.
https://learn.microsoft.com/en-us/dotnet/core/runtime-config/globalization#invariant-mode
Determines whether a .NET Core app runs in globalization-invariant mode without access to culture-specific data and behavior.
There was a problem hiding this comment.
Do we have such qualifications for other properties defined here that are only applicable in modern .NET apps? We wouldn't say ".NET Core" in documentation now either.
There was a problem hiding this comment.
All these properties don't work in .NET Framework either:
msbuild/src/MSBuild/MSBuild/Microsoft.Build.CommonTypes.xsd
Lines 2362 to 2393 in 1a6d753
Interestingly, they all refer to "the project" and not an "app".
I think what we have here is fine. Just wanted to check if the qualification was needed or not.
Related to dotnet/aspnetcore#47029.
Document the
InvariantGlobalizationproperty since we intend to set it in templates.