Question mode usage feedback updates.#9155
Merged
JanKrivanek merged 13 commits intodotnet:mainfrom Nov 18, 2023
Merged
Conversation
yuehuang010
commented
Aug 23, 2023
Member
|
@yuehuang010 , could I ask you to fix the build? |
Forgind
reviewed
Oct 6, 2023
Member
|
Spinned of from the #8881 changes |
Member
|
Hi @yuehuang010, The PR looks good to me, but could you reply to @Forgind questions above? |
JanKrivanek
reviewed
Oct 26, 2023
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks good to me.
I'm still opinionated on having a dedicated error resource string for failed incrementality check. If that's added - I'll sign off. I'm fine to be voted-off (hence I'm not requesting the change). Or if there is a good reason not to have a separate string for that - I'm ready to listen for reasons.
YuliiaKovalova
approved these changes
Oct 30, 2023
JanKrivanek
approved these changes
Nov 16, 2023
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
I have couple comments - but those are just minor suggestions for consideration. Feel free to resolve those.
Other than that - I'm happy with the current state.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating a task behavior to avoid False positives.
After using /question switch on several repro, I am changing a few tasks to reduce False Positive. These task will continue perform there operations as in a normal build. If they impact the incremental build, then it would appear in downstream error. These task should log there file activity so that it could be traced.
Touch and Delete tasks - demote error to warning.
WriteLinesToFile Task - remove questioning when WriteOnlyWhenDifferent is false.
GenerateResource Task - Fix missing message.