Fix microbenchmarks input files#1142
Merged
adamsitnik merged 4 commits intodotnet:masterfrom Jan 22, 2020
Merged
Conversation
billwert
approved these changes
Jan 22, 2020
Member
|
thanks @adamsitnik for a quick fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1132 I've forgotten to change the folder names used by input file helpers.
Yesterday @wfurt has tried to run the networking benchmarks and they have all failed due to missing files.
This PR fixes that. What worries me is that CI was green despite the benchmarks were failing. I am going to file a separate issue for that.