Add Remaining Extensions performance tests #1360
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter. Commit migrated from dotnet/extensions@7ce647c
Commit migrated from dotnet/extensions@18fcffb
Commit migrated from dotnet/extensions@34204b6
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96 Commit migrated from dotnet/extensions@689c4a8
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee Commit migrated from dotnet/extensions@04e957b
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185 Commit migrated from dotnet/extensions@9a4c61b
Commit migrated from dotnet/extensions@5b8b6c7
Commit migrated from dotnet/extensions@3ba072c
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d Commit migrated from dotnet/extensions@f3cd14a
Commit migrated from dotnet/extensions@f162f10
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7 Commit migrated from dotnet/extensions@c38f9c1
Commit migrated from dotnet/extensions@888bcba
Commit migrated from dotnet/extensions@888bcba
Commit migrated from dotnet/extensions@63cde57
Commit migrated from dotnet/extensions@63cde57
This includes the master branch of aspnet/HttpClientFactory Commit migrated from dotnet/extensions@557995e
This includes the master branch of aspnet/HttpClientFactory Commit migrated from dotnet/extensions@557995e
Use arcade Commit migrated from dotnet/extensions@f045899
Use arcade Commit migrated from dotnet/extensions@f045899
* Remove obsolete targets, properties, and scripts * Replace IsProductComponent with IsShipping * Undo bad merge to version.props * Update documentation, and put workarounds into a common file * Replace usages of RepositoryRoot with RepoRoot * Remove API baselines * Remove unnecessary restore feeds and split workarounds into two files * Enable PR checks on all branches, and disable autocancel Commit migrated from dotnet/extensions@f41cfde
* Remove obsolete targets, properties, and scripts * Replace IsProductComponent with IsShipping * Undo bad merge to version.props * Update documentation, and put workarounds into a common file * Replace usages of RepositoryRoot with RepoRoot * Remove API baselines * Remove unnecessary restore feeds and split workarounds into two files * Enable PR checks on all branches, and disable autocancel Commit migrated from dotnet/extensions@f41cfde
Commit migrated from dotnet/extensions@2f8e1fb
Commit migrated from dotnet/extensions@2f8e1fb
Commit migrated from dotnet/extensions@8f0f7fa
Commit migrated from dotnet/extensions@20ce03a
* Support netcoreapp3.1 TFM * Unpin SDK for source build * Update to preview1 branding Commit migrated from dotnet/extensions@32cc816
* Support netcoreapp3.1 TFM * Unpin SDK for source build * Update to preview1 branding Commit migrated from dotnet/extensions@32cc816
Commit migrated from dotnet/extensions@321a30c
Commit migrated from dotnet/extensions@321a30c
…-primitives-perf-move branch in performance repo
Conflicts: src/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/Microsoft.Extensions.Primitives.Performance.csproj src/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/Properties/AssemblyInfo.cs src/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
- Http benchmarks - Logging benchmarks - DI not needing InternalsVisibleTo - [ ] Enable DI tests needing InternalsVisibleTo
- [ ] Fix for removed internal types
JunTaoLuo
reviewed
Jun 17, 2020
| ServiceProviderMode = (ServiceProviderMode)Enum.Parse(typeof(ServiceProviderMode), value); | ||
| } | ||
| } | ||
| // internal ServiceProviderMode ServiceProviderMode { get; private set; } |
There was a problem hiding this comment.
Hey @halter73 @davidfowl do you know what the history here is? Specifically, are these benchmarks still relevant? Given I don't have much context here, I'm inclined to keep the benchmarks for each of the DI modes, but if these are no longer useful in any way, we can remove them.
Member
There was a problem hiding this comment.
Given I don't have much context here, I'm inclined to keep the benchmarks for each of the DI modes, but if these are no longer useful in any way, we can remove them.
I'm inclined to keep them too. Even if we aren't doing active perf work on DI now, it could be useful later. Is there some reason we cannot make Microsoft.Extensions.DependencyInjection's internals visable to this project?
There was a problem hiding this comment.
The problem is that the benchmarks app isn't strong named so IVT doesn't work. But I think what we should do here is turn strong name on, instead of removing the benchmarks. @maryamariyan is looking into do that now.
Contributor
Author
|
closed in favor of #1362 (it's odd, push force didnt update the PR so I tried close and re-opening the PR but now I cant reopen the PR for whatever reason). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @adamsitnik @JunTaoLuo
PR #1288 would add Microsoft.Extensions.Primitives perf tests.
This PR adds DI, Logging and Http perf tests too.