-
Notifications
You must be signed in to change notification settings - Fork 286
Perf Utf8Encoding for ARM64 comparison #1466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kunalspathak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
|
Results: SSE2 OFF vs SSE2 ONOff: AdvSimd OFF vs AdvSimd ONOff: |
pgovind
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice numbers!
adamsitnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @carlossanlop !
|
I'm just wondering if this will break the mono CI too. |
|
Maybe not. I just saw that @adamsitnik fixed the mono issue with a NoMono category. Nice! |
This one not because it's not using the forbidden constructor :D |
The purpose of this PR is to verify the performance of the recent AdvSimd.Arm64 improvements added to Utf16Utility.Validation.cs.
The
UTF8Encoding.GetByteCountmethod reaches the Utf16Utility.Validation.cs lines 82, 150 and 190, when called with the contents of the recently added text files containing long unicode strings.cc @kunalspathak @pgovind @adamsitnik