Skip to content

Fix: MS Build Console Pipeline Failure #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrewScoggins merged 1 commit into from
Aug 13, 2021
Merged

Fix: MS Build Console Pipeline Failure #1921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/tools/ScenarioMeasurement/Startup/InnerLoopMsBuildParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public IEnumerable<Counter> Parse(string mergeTraceFile, string processName, ILi
}
});

source.Source.Dynamic.AddCallbackForProviderEvent("Microsoft-Build", "EvaluateStop/Stop", evt =>
source.Source.Dynamic.AddCallbackForProviderEvent("Microsoft-Build", "Evaluate/Stop", evt =>
{
if(pid.HasValue && evt.ProcessID == pid.Value)
{
Expand Down Expand Up @@ -153,18 +153,18 @@ public IEnumerable<Counter> Parse(string mergeTraceFile, string processName, ILi
{
diffTOT.Add(firstRun["ThreadCSwitch"][i] - secondRun["ThreadCSwitch"][i]);
}
for(int i = 0; i < firstRun["EvaluateStop/Stop"].Count; i++)
for(int i = 0; i < firstRun["Evaluate/Stop"].Count; i++)
{
diffEBT.Add(firstRun["EvaluateStop/Stop"][i] - secondRun["EvaluateStop/Stop"][i]);
diffEBT.Add(firstRun["Evaluate/Stop"][i] - secondRun["Evaluate/Stop"][i]);
}

return new[] {
new Counter() { Name = "Generic Startup First Run", MetricName = "ms", TopCounter=true, Results = firstRun["Process/Stop"].ToArray() },
new Counter() { Name = "Generic Startup Second Run", MetricName = "ms", TopCounter=true, Results = secondRun["Process/Stop"].ToArray() },
new Counter() { Name = "Generic Startup Diff", MetricName = "ms", DefaultCounter=true, TopCounter=true, Results = diffGS.ToArray() },
new Counter() { Name = "Time on Thread Diff", MetricName = "ms", TopCounter=true, Results = diffTOT.ToArray() },
new Counter() { Name = "Build Evaluate Time First Run", MetricName = "ms", TopCounter=true, Results = firstRun["EvaluateStop/Stop"].ToArray() },
new Counter() { Name = "Build Evaluate Time Second Run", MetricName = "ms", TopCounter=true, Results = secondRun["EvaluateStop/Stop"].ToArray() },
new Counter() { Name = "Build Evaluate Time First Run", MetricName = "ms", TopCounter=true, Results = firstRun["Evaluate/Stop"].ToArray() },
new Counter() { Name = "Build Evaluate Time Second Run", MetricName = "ms", TopCounter=true, Results = secondRun["Evaluate/Stop"].ToArray() },
new Counter() { Name = "Build Evaluate Time Diff", MetricName = "ms", TopCounter=true, Results = diffEBT.ToArray() }
};
}
Expand Down