dotnet.py: --output is no longer supported with dotnet build/publish#2774
Merged
radical merged 1 commit intodotnet:mainfrom Dec 7, 2022
Merged
dotnet.py: --output is no longer supported with dotnet build/publish#2774radical merged 1 commit intodotnet:mainfrom
--output is no longer supported with dotnet build/publish#2774radical merged 1 commit intodotnet:mainfrom
Conversation
radical
added
the
pipeline blocker
radical
force-pushed
the
fix-build-sln
branch
from
d49ae71 to
d084643
Compare
.. with .sln files. Instead, pass `/p:PublishDir=..` to the build command. This changed in dotnet/sdk#29065, and broke `dotnet-runtime-perf` pipeline's blazor scenarios. ``` $ dotnet publish /home/helixbot/work/A8850905/p/performance/src/scenarios/blazorpizza/app/BlazingPizza.sln --configuration Release --output pub /p:NuGetPackageRoot=/home/helixbot/work/A8850905/w/A9A608EA/u/artifacts/packages/ /p:UseSharedCompilation=false /p:BuildInParallel=false /m:1 --framework net7.0 /p:_TrimmerDumpDependencies=true -bl:./traces/blazor_publish.binlog -p:WasmNativeWorkload=false MSBuild version 17.5.0-preview-22601-03+a2490dd3f for .NET /home/helixbot/work/A8850905/p/dotnet/sdk/8.0.100-alpha.1.22606.3/Current/SolutionFile/ImportAfter/Microsoft.NET.Sdk.Solution.targets(36,5): error NETSDK1194: The "--output" option isn't supported when building a solution. [/home/helixbot/work/A8850905/p/performance/src/scenarios/blazorpizza/app/BlazingPizza.sln] ``` Details: When building a solution, passing a relative path to `PublishDir` gets evaluated per-project. So, if we pass `-p:PublishDir=pub` then we get `pub/` sub-directories for each of the projects. But when used with `--output pub`, output for all the projects goes to the same directory. To have the same behavior use an absolute path.
radical
force-pushed
the
fix-build-sln
branch
from
d084643 to
7c28230
Compare
Member
Author
|
Running with this change in https://dev.azure.com/dnceng-public/public/_build/results?buildId=104271&view=logs&j=9331bb7a-642b-57f2-cf5f-0083d34246f4 with a test PR - dotnet/runtime#79328 . |
Member
Author
|
Without this the |
LoopedBard3
approved these changes
Dec 7, 2022
Member
LoopedBard3
left a comment
LoopedBard3
left a comment
There was a problem hiding this comment.
LGTM, once the test run finishes. Does this also need to be backported to release7.0?
Member
Author
The change seems to be only in the 8.0 sdk. |
radical
removed
the
pipeline blocker
NielsPilgaard
added a commit
to NielsPilgaard/EventStore-Client-Dotnet
that referenced
this pull request
Feb 16, 2023
This fixes publish failing with the error `error NETSDK1194: The "--output" option isn't supported when building a solution.` The `--output` flag has been deprecated, the recommended approach is to use `/p:PublishDir=..` instead. Reference: dotnet/performance#2774
|
@LoopedBard3 @radical this is also an issue in .NET 7. We upgraded our CI build image running on Azure DO, which bumped to a newer .NET 7 patch version. The same build where only the underlying build image has changed a patch version of .NET 7 now fails. Edit. It seems that this is actually expected. |
nkz-soft
added a commit
to nkz-soft/microservice-template
that referenced
this pull request
Feb 23, 2023
timothycoleman
pushed a commit
to kurrent-io/KurrentDB-Client-Dotnet
that referenced
this pull request
Feb 27, 2023
* Added 3 overloads of `AddEventStoreClient` These new methods provide access to the `IServiceProvider`, allowing easy configuration across environments. This is very useful when using EventStore on different environments, that use different EventStores. I currently have this code running in production, and it works very well in combination with a configuration manager such as Azure App Configuration, or Azure Key Vault. They allow constructing the following using the ServiceProvider: - Uri address - string connectionString - Action<EventStoreClientSettings` configureSettings I've also added: - 2 new private methods that do the actual registration - tests for all 3 public methods * Replace --output flag with /p:PublishDir This fixes publish failing with the error `error NETSDK1194: The "--output" option isn't supported when building a solution.` The `--output` flag has been deprecated, the recommended approach is to use `/p:PublishDir=..` instead. Reference: dotnet/performance#2774 * create packages folder if it doesn't exist before running `dotnet pack`
andrewlock
added a commit
to andrewlock/NetEscapades.EnumGenerators
that referenced
this pull request
Mar 6, 2023
andrewlock
added a commit
to andrewlock/NetEscapades.EnumGenerators
that referenced
this pull request
Mar 6, 2023
* Add integration test for netstandard * Fix publish command: dotnet/performance#2774
ProActive-Engineer
added a commit
to ProActive-Engineer/NetEscapades.EnumGenerators
that referenced
this pull request
Aug 19, 2023
* Add integration test for netstandard * Fix publish command: dotnet/performance#2774
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.. with .sln files. Instead, pass
/p:PublishDir=..to the build command.This changed in dotnet/sdk#29065, and broke
dotnet-runtime-perfpipeline's blazor scenarios.Fixes dotnet/runtime#79330 .