Skip to content

Added option for running benchmarks with physical promotion enabled. #3070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cincuranet merged 1 commit into from
Jun 7, 2023
Merged

Added option for running benchmarks with physical promotion enabled. #3070

cincuranet merged 1 commit into from
Jun 7, 2023

Conversation

@cincuranet
Copy link
Contributor

@cincuranet cincuranet commented Jun 7, 2023 •
edited
Loading

Contributes to #3069.

@cincuranet cincuranet self-assigned this Jun 7, 2023
@cincuranet cincuranet added enhancement New feature or request lab-infrastructure labels Jun 7, 2023
LoopedBard3
LoopedBard3 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

DrewScoggins
DrewScoggins approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cincuranet cincuranet merged commit 53ed18b into dotnet:main Jun 7, 2023
@cincuranet cincuranet deleted the physical-promotion branch June 7, 2023 19:09
@cincuranet cincuranet mentioned this pull request Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrewScoggins DrewScoggins DrewScoggins approved these changes

@LoopedBard3 LoopedBard3 LoopedBard3 approved these changes

@sblom sblom Awaiting requested review from sblom

@caaavik-msft caaavik-msft Awaiting requested review from caaavik-msft

Assignees

@cincuranet cincuranet

Labels

enhancement New feature or request lab-infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cincuranet @DrewScoggins @LoopedBard3