Skip to content

Fix targetting for 9.0.0 packages.#4523

Merged
LoopedBard3 merged 7 commits intodotnet:mainfrom
LoopedBard3:UpdateUtilCsproj
Oct 21, 2024
Merged

Fix targetting for 9.0.0 packages.#4523
LoopedBard3 merged 7 commits intodotnet:mainfrom
LoopedBard3:UpdateUtilCsproj

Conversation

@LoopedBard3
Copy link
Copy Markdown
Member

@LoopedBard3 LoopedBard3 commented Oct 17, 2024

Update Util.csproj to use the same TargetFramework assignment logic as other projects in ScenarioMeasurement. Also removed the no longer used LibrariesTargetFramework property from the Scenario Measurement Directory.Build.props.

Aside from Util.csproj changes, added temporary feeds with references for 9.0.0 packages to fix the build failure for now.

Fixes: #4524

…s other projects in ScenarioMeasurement. Also removed the no longer used LibrariesTargetFramework property from the Scenario Measurement Directory.Build.props.
@LoopedBard3 LoopedBard3 changed the title Update Util.csproj to use the same TargetFramework assignment logic as nearby projects Update Util.csproj to use the same TargetFramework assignment logic as nearby projects and add 9.0.0 package feed Oct 17, 2024
@LoopedBard3
Copy link
Copy Markdown
Member Author

The fsharpmicro runs seem to still hit issues with FSharp.Core missing for version >= 9.0.100, though I am not finding the proper dependency in darc to get this to work. This is currently being hit so I think we should get this merged to fix most of the other failing cases and come back to FSharp.Core in a different PR.

@LoopedBard3 LoopedBard3 changed the title Update Util.csproj to use the same TargetFramework assignment logic as nearby projects and add 9.0.0 package feed Fix targetting for 9.0.0 packages. Oct 21, 2024
@DrewScoggins
Copy link
Copy Markdown
Member

Do we understand all of the other failures that we are seeing here? From a quick glance it looks like blazor_scenarios, sdk_scenarios, and Ubuntu micros.

Copy link
Copy Markdown
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failures are unrelated and will be fixed in later PRs.

@LoopedBard3
Copy link
Copy Markdown
Member Author

Partially, blazor_scenarios main seem to be failing to install wasm-tools, linux micro runs has 4 partitions failing due to a security exception or something when trying to run some SSL stream microbenchmarks, and fsharpmicro main are failing due to not being able to find the dependency for FSharp.Core (similar to what this is fixing and mentioned above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tool builds failing on net9.0 runs due to NU1102

2 participants