Set System.Net.SecurityProtocolType on Windows Prior to Executing Install Script#5088
Merged
LoopedBard3 merged 1 commit intodotnet:mainfrom Jan 29, 2026
Conversation
…net install script
Member
|
@LoopedBard3 @DrewScoggins could you please approve? Without this it fails to acquire the SDK on our Windows CI machines. |
LoopedBard3
approved these changes
Jan 29, 2026
EgorBo
added a commit
to dotnet/runtime
that referenced
this pull request
Jan 29, 2026
…123723) Requires a patched version of dotnet/performance to set the TLS version in powershell on windows. dotnet/performance PR here: dotnet/performance#5088 --------- Co-authored-by: Egor Bogatov <egorbo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/dotnet.py installwill fail on slightly older windows hosts due to the TLS defaulting to an older version. This PR changes the install command to set the version to what is required to executedotnet-install.ps1(reference here: https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-install-script). Without this fix there does not seem to be an easy workaround to usedotnet.py installon systems without TLS1.2 set as default.