Auto-detect runtime_flavor for wasm_coreclr micro benchmarks#5155
Merged
LoopedBard3 merged 2 commits intodotnet:mainfrom Mar 17, 2026
Merged
Auto-detect runtime_flavor for wasm_coreclr micro benchmarks#5155LoopedBard3 merged 2 commits intodotnet:mainfrom
LoopedBard3 merged 2 commits intodotnet:mainfrom
Conversation
For wasm_coreclr micro benchmark runs, runtime_flavor is not passed via YAML, causing RuntimeType to be set to 'None' in configurations. This means results never appear in test history or the perf autofiler. Add auto-detection of runtime_flavor for wasm_coreclr micro benchmarks, setting it to 'coreclr', following the existing pattern used by Android and iOS scenarios. This fix does not modify wasm (mono) behavior to avoid breaking existing test history reports. Fixes the same root cause as dotnet#5153 but with a more targeted approach that only affects wasm_coreclr. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes missing RuntimeType metadata for wasm_coreclr micro benchmark runs by auto-populating runtime_flavor so run configurations are stored with RuntimeType=coreclr (enabling test history and perf autofiler visibility), without changing existing wasm (mono) behavior.
Changes:
- Add auto-detection to set
args.runtime_flavor = "coreclr"forrun_kind="micro"withruntime_type="wasm_coreclr".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
DrewScoggins
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For wasm_coreclr micro benchmark runs, runtime_flavor is not passed via YAML, causing RuntimeType to be set to 'None' in configurations. This means results never appear in test history or the perf autofiler.
Add auto-detection of runtime_flavor for wasm_coreclr micro benchmarks, setting it to 'coreclr', following the existing pattern used by Android and iOS scenarios. This fix does not modify wasm (mono) behavior to avoid breaking existing test history reports.
Fixes the same root cause as #5153 but with a more targeted approach that only affects wasm_coreclr.
This will fix the RunConfigurations from saving as
{"CompilationMode":"wasm","RunKind":"micro","RuntimeType":"None"}to saving as{"CompilationMode":"wasm","RunKind":"micro","RuntimeType":"coreclr"}