Add benchmarks for ISet<T> (de)serialization and general framework fo…#540
Merged
adamsitnik merged 3 commits intodotnet:masterfrom Jul 18, 2019
Merged
Add benchmarks for ISet<T> (de)serialization and general framework fo…#540adamsitnik merged 3 commits intodotnet:masterfrom
adamsitnik merged 3 commits intodotnet:masterfrom
Conversation
…r generic collections
ahsonkhan
reviewed
Jun 5, 2019
|
|
||
| namespace System.Text.Json.Serialization.Tests | ||
| { | ||
| public class WriteGenericCollection |
Contributor
There was a problem hiding this comment.
File mismatch. ReadJson.X has the test for Write and vice versa.
Contributor
There was a problem hiding this comment.
Is there another commit coming that resolves this @layomia ?
ahsonkhan
reviewed
Jun 5, 2019
| } | ||
|
|
||
| [Benchmark] | ||
| public ISet<string> DeserializeISet() |
Contributor
There was a problem hiding this comment.
Please share the perf results of any new tests added within the PR you add them in.
Nevermind, I see it in the PR: dotnet/corefx#38210
Contributor
There was a problem hiding this comment.
Looking at the Error/Std Dev of some of the results shared, I recommend commenting out the RecommendedConfig before running the tests locally to improve accuracy.
For example, this is quite inaccurate:
| DeserializeISet | 2 | 21,030.9 ns | 3,649.67 ns | 10,412.72 ns |
|---|
ahsonkhan
reviewed
Jun 5, 2019
ahsonkhan
approved these changes
Jun 5, 2019
Member
|
@layomia similar to other stale PRs (#478, #530, #589) I have cloned your fork, updated the code and pushed some fixes. I need to make sure that we don't regress it for 3.0. PTAL at my changes dotnet run -c Release -f netcoreapp3.0 --filter *WriteJson<*Set*>* *ReadJson<*Set*>* --joinBenchmarkDotNet=v0.11.3.1003-nightly, OS=Windows 10.0.18362
Intel Xeon CPU E5-1650 v4 3.60GHz, 1 CPU, 12 logical and 6 physical cores
.NET Core SDK=3.0.100-preview7-012697
[Host] : .NET Core 3.0.0-preview7-27826-20 (CoreCLR 4.700.19.32603, CoreFX 4.700.19.32613), 64bit RyuJIT
Job-KNHVRD : .NET Core 3.0.0-preview7-27826-20 (CoreCLR 4.700.19.32603, CoreFX 4.700.19.32613), 64bit RyuJIT
IterationTime=250.0000 ms MaxIterationCount=20 MinIterationCount=15
WarmupCount=1
|
Contributor
Author
|
@adamsitnik LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r generic collections
cc @ahsonkhan, @steveharter, @adamsitnik , @billwert