Make it possible to publish --self-contained MicroBenchmarks.csproj#591
Merged
adamsitnik merged 1 commit intodotnet:masterfrom Jun 27, 2019
Merged
Make it possible to publish --self-contained MicroBenchmarks.csproj#591adamsitnik merged 1 commit intodotnet:masterfrom
adamsitnik merged 1 commit intodotnet:masterfrom
Conversation
…rade issue when publishing
billwert
approved these changes
Jun 27, 2019
Contributor
billwert
left a comment
There was a problem hiding this comment.
I imagine this has no impact on any measurements, so it seems fine.
jorive
approved these changes
Jun 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of today, it's impossible to publish a self-contained version of
MicroBenchmarks.csprojdue to a package downgrade issue.PS C:\Projects\performance\src\benchmarks\micro> dotnet publish -c Release -f netcoreapp3.0 --self-contained -r win10-x64 MicroBenchmarks.csprojThe source of issues are the 3rd party JSON serializer benchmarks that use Jil, which uses Sigil which uses a very old version of
NETStandard.Library 1.5.0-rc2-24027which referencesMicrosoft.Win32.Primitives 4.0.1-rc2-24027.We can't update Jil because we already use the latest version. I think that we should rather not remove it because it's one of the fastest JSON serializers and it's good to have it for competitive comparison with System.Text.Json.
So my proposal is just to listen to the compiler and add both references in explicit way.
@billwert this is going to help me with making it possible to run the performance repo microbenchmarks with @sebastienros infrastructure and in the future might become usefull if we decide to separate benchmarks build and run into two separate steps (we are going to need a publish, self-contained project then)