Make it possible to build MicroBenchmarks.sln from Visual Studio#594
Merged
adamsitnik merged 10 commits intodotnet:masterfrom Jun 29, 2019
Merged
Make it possible to build MicroBenchmarks.sln from Visual Studio#594adamsitnik merged 10 commits intodotnet:masterfrom
adamsitnik merged 10 commits intodotnet:masterfrom
Conversation
…ensions, not MicroBenchmarks.csproj this allows for removing an old VS build order workaround from solution file
…ognize it as test project and show all source files
adamsitnik
commented
Jun 27, 2019
adamsitnik
commented
Jun 27, 2019
adamsitnik
commented
Jun 27, 2019
adamsitnik
commented
Jun 27, 2019
Member
Author
|
Hmm half of the legs passed, half not. All failed with the following mysterious error: I can not reproduce it locally... need to wrap my head around it |
jorive
reviewed
Jun 27, 2019
ViktorHofer
reviewed
Jun 28, 2019
ViktorHofer
reviewed
Jun 28, 2019
Member
ViktorHofer
left a comment
There was a problem hiding this comment.
Awesome that you switched to Directory.Build.props 👍👍👍
…o use daily bits, dotnet/core#2924) remove myget feed (it's not needed anymore)
adamsitnik
commented
Jun 28, 2019
adamsitnik
commented
Jun 28, 2019
Member
Author
jorive
reviewed
Jun 28, 2019
jorive
reviewed
Jun 28, 2019
jorive
reviewed
Jun 28, 2019
billwert
approved these changes
Jun 28, 2019
This was referenced Jul 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today I have tried to open
MicroBenchmarks.slnfrom a fresh copy of the repo (no previous builds or restores) and I have failed.I really want to make it easy for devs to work with the existing benchmarks and add new ones so I decided to fix it.
This PR simplifies few things and makes it work again.
Before:
After: