Merge Master into Dev16.0.x#4425
Merged
Merged
Conversation
All usages were protected by a lock. Use the collection itself as a lock object, removing a field. Convert private property to field.
There's no longer any dispose logic for AggregateCrossTargetProjectContext.
Make non-generic, inlining sole type parameter of DependenciesRuleChangeContext. Also removes IRuleChangeContext.
Add test to cover this scenario.
Memory reduction
…romFind Don't handle TextView so opening results from find works
…ssage Do not warn about using a pre-release sdk to build
…t-pack Do not warn about licensing url being deprecated in future versions
This error was introduced in 3744d8f Fixes dotnet#4313
Ternary with `default` was returning the non-nullable default (such as `false` or the enum zero value). Empty strings were not being converted to `null` in one of the string helpers, contradicting the other string forms and the documentation.
For ImmutableDictionary, this extension method will be chosen over Enumerable.Count. This version uses the non-allocated enumerator provided by ImmutableDictionary. Currently used in GroupedByTargetTreeViewProvider.BuildTreeAsync.
Thanks for the suggestions Drew Co-Authored-By: davidwengier <david.wengier@microsoft.com>
Documenting the Mind of Kean
Update meta analyzers in ruleset
This brings the documentation files into the solution so that they are easier to edit and appear in search results.
…ned-api remove use of IProjectLockService
We weren't waiting for changes to be applied before we closed the batch. This path is currently synchronous so it's just by change that this currently works.
* Fix violations of IDE0059
…Dev16 Allow design-time build logging to be turned on Dev16/suffixes
Make sure to apply changes under batch
* Remove commented out logging for launch settings to resolve IDE0060 compiler warnings * Fix IDE0060 violations
ClearAllErrors was the only method calling this method and would never break out.
Add minimal project for documentation
…xe (dotnet#4400) * Add AppServicePublish capability to all SDK projects that output to exes (excluding winexe) * Add FolderPublish capability to all .NET SDK projects
Member
Contributor
Author
|
@davkean It needs to be in the next 6 hours to ensure it makes it before the snap |
When we've never been set an active editor context, just return the one based on the active configuration. This combined with dotnet/roslyn#32153, unblocks Razor.
Turn on language-service integration rewrite
Contributor
Author
|
Including #4419 in this merge. This is the last payload making it from master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev16.0.x goes into QB approval mode Today at 6pm (2am Sat UTC)
With this merged that means
dev16.0.x -> Dev16 Preview 2
master -> Dev16 Preview 3