Skip test on mac#12229
Merged
davidwengier merged 1 commit intodotnet:mainfrom Sep 15, 2025
Merged
Conversation
DustinCampbell
approved these changes
Sep 15, 2025
Member
DustinCampbell
left a comment
DustinCampbell
left a comment
There was a problem hiding this comment.
FWIW, I've had tests in this class fail locally on Windows in the past. I think they're generally flaky and something on Mac just makes them more flaky.
| } | ||
|
|
||
| [Fact] | ||
| [ConditionalFact(Is.Windows)] |
Member
There was a problem hiding this comment.
Consider adding a comment to indicate why this is Windows-only.
DustinCampbell
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is flaky on Mac, and has broken a few of my PR runs, and even our official
mainCI run a few times.Justification: