Remove old options page#12233
Merged
davidwengier merged 2 commits intodotnet:mainfrom Sep 17, 2025
Merged
Conversation
chsienki
approved these changes
Sep 16, 2025
| } | ||
|
|
||
| [LocCategory(nameof(VSPackage.Formatting))] | ||
| [LocDescription(nameof(VSPackage.Setting_FormattingOnTypeDescription))] |
Member
There was a problem hiding this comment.
Are these LOC strings still used by the new options, or can they go to?
Member
Author
There was a problem hiding this comment.
Yeah, they're referenced from the unified settings json file
2 tasks
This was referenced Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by dotnet/roslyn#80290
You could still get to this page by going to some other languages "More Settings" screen, but the all of the settings were migrated long ago, so getting rid of this gets rid of a single "Advanced" link in our More Settings, which used to show this screen, but in current builds it just takes you to the new settings UI anyway, so this was really unnecessary.