Redirect the older named assembly too#12239
Merged
chsienki merged 1 commit intodotnet:mainfrom Sep 17, 2025
Merged
Conversation
Member
Author
|
@dotnet/razor-tooling for reviews, thanks! |
davidwengier
approved these changes
Sep 17, 2025
Member
davidwengier
left a comment
davidwengier
left a comment
There was a problem hiding this comment.
😲
I was going to ask yesterday if we could do this, but I stopped myself, because surely we can't just return a completely different assembly, that's crazy! But if it's crazy and it works...
Member
Author
We're honestly lucky, because the dependencies are either the same, or will just get loaded and ignored. There is a narrow window of when this would work, but thankfully we are in it heh. |
This was referenced Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/vscode-csharp#8621
Added a test and manually patched a repro-ing VS Code instance to confirm it fixes.