Add With* convenience methods to SourceSpan#13005
Merged
Conversation
Agent-Logs-Url: https://github.com/dotnet/razor/sessions/0fe1bde6-bf65-4d15-b842-d85d7ca68e41 Co-authored-by: chsienki <16246502+chsienki@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add With* convenience methods to SourceSpan
Add With* convenience methods to SourceSpan
Apr 3, 2026
…tTagHelperResolutionPhase files Agent-Logs-Url: https://github.com/dotnet/razor/sessions/aee1b7aa-43a0-4cd8-848f-b844edb970a0 Co-authored-by: chsienki <16246502+chsienki@users.noreply.github.com>
chsienki
reviewed
Apr 3, 2026
chsienki
reviewed
Apr 3, 2026
Agent-Logs-Url: https://github.com/dotnet/razor/sessions/97b3a1f3-564f-4a27-84ab-64ad0fa5ccf5 Co-authored-by: chsienki <16246502+chsienki@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…..) constructors Agent-Logs-Url: https://github.com/dotnet/razor/sessions/41e03d10-22e7-4198-91ac-8127387721ae Co-authored-by: chsienki <16246502+chsienki@users.noreply.github.com>
….) calls Agent-Logs-Url: https://github.com/dotnet/razor/sessions/d7f252db-e4ba-4bae-81d4-4145549e627d Co-authored-by: chsienki <16246502+chsienki@users.noreply.github.com>
davidwengier
approved these changes
Apr 9, 2026
Co-authored-by: chsienki <16246502+chsienki@users.noreply.github.com>
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultTagHelperResolutionPhase.cs(2 conflicts) andDefaultTagHelperResolutionPhase.ComponentTagHelperResolver.cs(1 conflict) by taking main'sMergeSourceSpanscalls over ourWith*chains at those sites