Fix NRE in CohostDocumentPullDiagnosticsEndpointBase.GetDiagnosticsAsync#13044
Merged
Fix NRE in CohostDocumentPullDiagnosticsEndpointBase.GetDiagnosticsAsync#13044
Conversation
When the remote service call fails, TryInvokeAsync catches the exception and returns default. For ImmutableArray<T>, default has a null internal array, so accessing .Length throws NullReferenceException. The existing guard only checked cancellationToken.IsCancellationRequested, which handles the cancellation path but not the error path. Add a diagnostics.IsDefault check to return null when the remote call fails, matching the existing cancellation behavior. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2601367 -- (111K hits across 18.0-18.7).
davidwengier
approved these changes
Apr 13, 2026
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the remote service call fails, TryInvokeAsync catches the exception and returns default. For ImmutableArray, default has a null internal array, so accessing .Length throws NullReferenceException. The existing guard only checked cancellationToken.IsCancellationRequested, which handles the cancellation path but not the error path.
Add a diagnostics.IsDefault check to return null when the remote call fails, matching the existing cancellation behavior.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2601367 -- (111K hits across 18.0-18.7).