Random code cleanup found during repo merge work#13053
Merged
davidwengier merged 7 commits intodotnet:mainfrom Apr 15, 2026
Merged
Random code cleanup found during repo merge work#13053davidwengier merged 7 commits intodotnet:mainfrom
davidwengier merged 7 commits intodotnet:mainfrom
Conversation
ToddGrun
reviewed
Apr 15, 2026
| return | ||
| // No allowed failures. Yay! | ||
| false; | ||
| return error switch |
Member
There was a problem hiding this comment.
Could also Debug.Assert or somesuch
Member
Author
There was a problem hiding this comment.
Honestly suppressing never occurred to me. Too much talking the AI out of suppressing everything it hits I guess
chsienki
approved these changes
Apr 15, 2026
This was referenced Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we merge into Roslyn we get a lot more analyzers running on our code. This fixes some of the warnings produced in the Roslyn build, plus some random dead code that I, or the build, found.
There are more warnings than just these, but these are things I consider objectively good :)