Fixed wrong completion icons#5999
Conversation
DoctorKrolic
requested review from
a team,
NTaylorMullen,
allisonchou,
davidwengier,
ryanbrandenburg and
sharwell
as code owners
100% Agree @DoctorKrolic! We actually have a backlog item to migrate our language server to be purely language server driven where through custom messages the server itself can delegate to C# etc. and then post-process on the language server if needed. It's a bit longer leaded but will ultimately get us into a position to make experiences better. Love that you're digging through all this code and helping us out here ❤️ |
NTaylorMullen
left a comment
NTaylorMullen
left a comment
There was a problem hiding this comment.
Once again you're awesome! Thank you for the contribution and help!
|
This is no longer a valid PR as #6012 was merged, closing it |
Oh geez, I should have merged this earlier for the contribution though. My apologies @DoctorKrolic ! |
2 participants
Fixes: #5793
Before:
"for" and "foreach" completions has weird icons
After:
All icons are ok
Yet another bug, occured because of completions post processing. In general having such post processing is the opposit of an idea of a language server, because every client needs to implement this post processing on his own. I'm not a fan of this approach at all! 😠 All functionality should be processed on the server side!