Skip to content

Pass formatting options in snippets#6049

Merged
dibarbet merged 2 commits into
dotnet:mainfrom
dibarbet:snippet_formatting
Feb 8, 2022
Merged

Pass formatting options in snippets#6049
dibarbet merged 2 commits into
dotnet:mainfrom
dibarbet:snippet_formatting

Conversation

@dibarbet
Copy link
Copy Markdown
Member

@dibarbet dibarbet commented Feb 4, 2022

Summary of the changes

  • Uses document options from client and passes them to C# to retrieve the razor formatted snippet text.

Tested

Copy link
Copy Markdown

@NTaylorMullen NTaylorMullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy peezy! @ryanbrandenburg do you have a tracker for integration tests we need to add? We should definitely include snippet expansions as one

@ryanbrandenburg
Copy link
Copy Markdown

List of desired integration tests lives here: #5952. I can add Snippet expansion and let @dibarbet flesh it out.

@dibarbet dibarbet marked this pull request as ready for review February 8, 2022 02:30
Copy link
Copy Markdown

@NTaylorMullen NTaylorMullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dibarbet dibarbet merged commit 95d0323 into dotnet:main Feb 8, 2022
@dibarbet dibarbet deleted the snippet_formatting branch February 8, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants