Support item defaults in completion#6229
Merged
Merged
Conversation
dibarbet
requested review from
a team,
NTaylorMullen,
allisonchou,
davidwengier,
ryanbrandenburg and
sharwell
as code owners
dibarbet
commented
Mar 30, 2022
| var translatedCharacter = editPosition.Character - offset; | ||
| internal static Range TranslateRange(Position hostDocumentPosition, Position projectedPosition, Range? wordRange, Range textEditRange) | ||
| { | ||
| var offset = projectedPosition.Character - hostDocumentPosition.Character; |
Member
Author
There was a problem hiding this comment.
just moved into its own method
davidwengier
approved these changes
Mar 30, 2022
|
It looks like the Integration tests hung? @sharwell I was under the impression that HangMitigatingToken should have protected us from this. I'll look at the dump. |
|
Looking at the logs it seems like the LSP failed at launch and VS may have been in a bad state? |
NTaylorMullen
approved these changes
Mar 30, 2022
NTaylorMullen
left a comment
NTaylorMullen
left a comment
There was a problem hiding this comment.
thanks @dibarbet looks awesome!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Razor side PR for dotnet/roslyn#60466