Not poisoning restricted types known to be stack only.#22275
Merged
Conversation
TypedReference ArgIterator RuntimeArgumentHandle Fixes:#dotnet#22198
Member
Author
|
@dotnet/roslyn-compiler - please take a look |
Member
Author
|
CC @jaredpar - for ask mode approval. |
jaredpar
approved these changes
Sep 21, 2017
cston
reviewed
Sep 21, 2017
| } | ||
|
|
||
| [Fact()] | ||
| public void NoTypedRefBox2() |
Contributor
There was a problem hiding this comment.
How does this differ from NoTypedRefBox1? Consider adding a comment.
cston
approved these changes
Sep 21, 2017
Member
Author
|
Microsoft.CodeAnalysis.Editor.UnitTests.Structure.StructureTaggerTests.CSharpOutliningTagger_RegionIsNotDefinition failed windows_debug_unit32_prtest.
|
Member
Author
|
test windows_debug_unit32_prtest please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not poisoning restricted types known to be stack only. (as per ECMA 335)
Fixes:#22198
===
There are technical reasons for which making RestrictedTypes ref structs is advantageous. In fact it is already done in some cases - see example: https://github.com/dotnet/corert/blob/f23fb52ce14fa680bcebc07eab9a20fa8780e47f/src/ILCompiler.TypeSystem/tests/CoreTestAssembly/Platform.cs#L71
We do not need to poison these types with Obsolete attribute when
ref structsyntax is used. The stack-only semantics of these types is widely known and poisoning can only lead to compat troubles.