Revert "Make compilation outputs available via a workspace service#35526
Closed
dpoeschl wants to merge 1 commit intodotnet:master-vs-depsfrom
Closed
Revert "Make compilation outputs available via a workspace service#35526dpoeschl wants to merge 1 commit intodotnet:master-vs-depsfrom
dpoeschl wants to merge 1 commit intodotnet:master-vs-depsfrom
Conversation
…otnet#34809)" This reverts commit 3bdbd56.
Member
|
@dpoeschl Was this worked out via binary search? I admit it's not clear to me why this would have been the break... |
Contributor
Author
|
@jasonmalinowski Yes, basically a binary search (but carefully executed to watch out for non-linear history). It's not clear to me either. Dumping some info: 2 consecutive commits:
Additionally, I made a passing insertion using latest master-vs-deps but with just this change reverted. |
Contributor
Author
|
FYI @jasonmalinowski @tmat @jinujoseph I've reopened this against master-vs-deps, since we're running out of time and don't have a resolution on fixing the problem on the VS side. |
Contributor
Author
|
XAML team is attempting a solution on the VS side. This is on hold unless really needed later. |
svick
added a commit
to metalama/Metalama.Compiler
that referenced
this pull request
Oct 14, 2024
svick
added a commit
to metalama/Metalama.Compiler
that referenced
this pull request
Oct 14, 2024
…roslyn dotnet#35526 Merge Roslyn 4.12 preview from SDK 9.0 RC 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Original PR #34809)
This change broke some unit tests on the VS side with a
System.Reflection.ReflectionTypeLoadException : Unable to load one or more of the requested types.See https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/179585 for details.