Refactor indentation API#57529
Open
tmat wants to merge 2 commits into
Open
Conversation
ghost
added
the
Contributor
Contributor
|
I don't have an answer here on what we should be doing. However, this needs to be discussed as there is high chance this can lead to problems (which we dealt with in the past, leading to the current design). Tagging @jasonmalinowski @sharwell |
jasonmalinowski
requested changes
Nov 3, 2021
Member
|
Yeah, we are keeping this path sync for the typing performance reason as @CyrusNajmabadi correctly calls out -- what would this look like to have both sync/async paths? Or do we have some better way to structure the code? |
Member
Author
|
@CyrusNajmabadi @jasonmalinowski How does it look now? |
Member
Author
|
See #57553 for future direction |
tmat
force-pushed
the
AsyncIndentation
branch
from
916555c to
1ce822a
Compare
tmat
force-pushed
the
AsyncIndentation
branch
from
1ce822a to
d260cb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoist
WaitAndGetResultto the invoking command handler on one code path and avoid it completely in others.Depends on #58904