Fix incremental build failures#58429
Conversation
These projects were expecting but not creating XML documentation files.
These projects were expecting but not creating output binaries.
ghost
added
the
Forgind
left a comment
Forgind
left a comment
There was a problem hiding this comment.
I'm assuming you don't have any files that aren't copied in the list?
sharwell
force-pushed
the
incremental-build
branch
from
279ca79 to
05f8bf1
Compare
@Forgind I'm not sure I understand the question here |
| --> | ||
| <PropertyGroup Condition="'$(RunAnalyzersDuringBuild)' == ''"> | ||
| <RunAnalyzersDuringBuild Condition="'$(DesignTimeBuild)' != 'true' AND '$(ContinuousIntegrationBuild)' != 'true' AND !('$(RoslynEnforceCodeStyle)' == 'true' OR '$(RunCodeAnalysis)' == 'true')">false</RunAnalyzersDuringBuild> | ||
| <RunAnalyzersDuringBuild Condition="'$(RoslynEnforceCodeStyle)' != 'true' AND '$(RunCodeAnalysis)' != 'true'">false</RunAnalyzersDuringBuild> |
There was a problem hiding this comment.
Is this change required for this fix or is just a cleanup?
There was a problem hiding this comment.
➡️ Required for this fix
There was a problem hiding this comment.
This line fixes the following error:
1>FastUpToDate: Input UpToDateCheckInput item 'C:\dev\roslyn\artifacts\obj\Microsoft.CodeAnalysis.XunitHook\Debug\net472\Microsoft.CodeAnalysis.XunitHook.csproj.BuildWithSkipAnalyzers' is newer (1/4/2022 7:24:46 AM) than earliest output 'C:\dev\roslyn\artifacts\obj\Microsoft.CodeAnalysis.XunitHook\Debug\net472\Microsoft.CodeAnalysis.XunitHook.xml' (1/4/2022 7:24:46 AM), not up to date. (Microsoft.CodeAnalysis.XunitHook)
mavasani
left a comment
mavasani
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this Sam!
| <!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information. --> | ||
| <Project> | ||
| <Import Project="..\..\..\Directory.Build.targets" /> | ||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.targets', '$(MSBuildThisFileDirectory)../'))" /> |
There was a problem hiding this comment.
Why do we need this set of changes?
There was a problem hiding this comment.
This is not strictly required, but it unifies all cases where a nested Directory.Build.targets is provided to import PackageProject.targets (previously the Import line varied based on file location, so copy/paste was potentially problematic). All copies of this file are now identical.
That wasn't very clear, and I actually don't remember what exactly I meant. I believe the bug BenVillalobos had been trying to fix was when a file is in the list of files to copy but shouldn't actually be copied for some other reason, so it's skipped. If we keep touching the CopyUpToDate marker, it can keep building. I think that was a somewhat unusual case? But worth verifying that building several times in a row doesn't rebuild the target. |
6 participants
No description provided.