🐇 Avoid allocations for .globalconfig parsing when possible#58725
Closed
sharwell wants to merge 1 commit into
Closed
🐇 Avoid allocations for .globalconfig parsing when possible#58725sharwell wants to merge 1 commit into
sharwell wants to merge 1 commit into
Conversation
ghost
added
the
sharwell
force-pushed
the
faster-sections
branch
from
67829eb to
ab2a04c
Compare
chsienki
approved these changes
Jan 12, 2022
Member
|
@sharwell Implementation LGTM. I know you had some questions around testing. Anything I can help with? |
sharwell
changed the title
Contributor
Author
|
Superseded by #59301 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates ~94% of allocations under
GetOptionsForSourcePathbased on AB#1458595.🚧 Still needs tests