Revert "Merge pull request #57132 from CyrusNajmabadi/branchId3"#58814
Closed
CyrusNajmabadi wants to merge 1 commit into
Closed
Revert "Merge pull request #57132 from CyrusNajmabadi/branchId3"#58814CyrusNajmabadi wants to merge 1 commit into
CyrusNajmabadi wants to merge 1 commit into
Conversation
ghost
added
the
CyrusNajmabadi
force-pushed
the
revertBranchId
branch
from
c04a5e8 to
3fd6248
Compare
Contributor
Author
|
@sharwell @jasonmalinowski for review. This does appear to be the source of some of hte memory regressions we've found. Verified by @genlu |
Member
|
@CyrusNajmabadi I signed off on the 17.1 version; if we decide not to take that I can re-sign off on this one too. |
Contributor
Author
|
@jasonmalinowski do we need to take this? or will the 17.1 fix automatically merge into main? |
Contributor
Author
|
Ok. This will flow into main naturally. Closing this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 83a728a, reversing
changes made to a4ec465.
We're seeing a bad perf regression around OOP that happeend over a period of time which included this risky change. This PR exists so we can make a build/insertion to see if it fixes the issue.