Skip to content

Assert compiler diagnostics in param-null checking test#58951

Merged
sharwell merged 1 commit into
dotnet:mainfrom
Youssef1313:patch-20
Jan 21, 2022
Merged

Assert compiler diagnostics in param-null checking test#58951
sharwell merged 1 commit into
dotnet:mainfrom
Youssef1313:patch-20

Conversation

@Youssef1313
Copy link
Copy Markdown
Member

@Youssef1313 Youssef1313 commented Jan 19, 2022

Follow-up to #58938

@ghost ghost added Community The pull request was submitted by a contributor who is not a Microsoft employee. Area-IDE labels Jan 19, 2022
@Youssef1313
Copy link
Copy Markdown
Member Author

Youssef1313 commented Jan 21, 2022

@sharwell @CyrusNajmabadi Can you review this test-only change?

@sharwell sharwell merged commit 0be1804 into dotnet:main Jan 21, 2022
@ghost ghost added this to the Next milestone Jan 21, 2022
@Youssef1313 Youssef1313 deleted the patch-20 branch January 21, 2022 16:26
@RikkiGibson
Copy link
Copy Markdown
Member

RikkiGibson commented Jan 25, 2022

Thanks @Youssef1313!

@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P1 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sharwell sharwell sharwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

17.2.P1

Development

Successfully merging this pull request may close these issues.

3 participants

@Youssef1313 @RikkiGibson @sharwell