Skip to content

Fix Roslyn Diagnostic Window and add Workspace panel#59035

Merged
tmat merged 1 commit into
dotnet:mainfrom
tmat:DiagWindow
Jan 28, 2022
Merged

Fix Roslyn Diagnostic Window and add Workspace panel#59035
tmat merged 1 commit into
dotnet:mainfrom
tmat:DiagWindow

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Jan 24, 2022

A couple of issues:

  • ProvideToolWindow attribute was missing
  • PerfMargin.DataModel was incorrectly indexing into array

Copy link
Copy Markdown
Contributor

@ryzngard ryzngard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think I understand what the issue was, but a description wouldn't hurt :)

@tmat tmat enabled auto-merge (squash) January 27, 2022 22:31
@tmat tmat merged commit 7f51127 into dotnet:main Jan 28, 2022
@ghost ghost added this to the Next milestone Jan 28, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P1 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants