Support codespace in dotnet/roslyn#59074
Conversation
jmarolf
commented
Jan 26, 2022
jmarolf
commented
- add in the devcontainer folder so codespaces knows how to construct a container for this repo
- add a set of recommended settings so VS Code will auto-install these in a codespace
- update our file mappings for VS Code in this repo
- add default settings for the omnisharp extension
- add settings for powershell to not auto-popup on install
- use dnceng schema for pipelines
… container for this repo
ghost
added
the
Co-authored-by: Fred Silberberg <fred@silberberg.xyz>
Co-authored-by: Fred Silberberg <fred@silberberg.xyz>
333fred
left a comment
333fred
left a comment
There was a problem hiding this comment.
We should document this in our readmes as well.
| # Install V8 Engine | ||
| SHELL ["/bin/bash", "-c"] | ||
|
|
||
| RUN curl -sSL "https://netcorenativeassets.blob.core.windows.net/resource-packages/external/linux/chromium-v8/v8-linux64-rel-8.5.183.zip" -o ./v8.zip \ | ||
| && unzip ./v8.zip -d /usr/local/v8 \ | ||
| && echo $'#!/usr/bin/env bash\n\ | ||
| "/usr/local/v8/d8" --snapshot_blob="/usr/local/v8/snapshot_blob.bin" "$@"\n' > /usr/local/bin/v8 \ | ||
| && chmod +x /usr/local/bin/v8 No newline at end of file |
There was a problem hiding this comment.
ah, this is for people who need wasm to work. I'll submit a follow up PR to remove this section. the runtime needs this in their docker file: https://github.com/dotnet/runtime/blob/main/.devcontainer/Dockerfile but we do not
| "*.xlf": "xml", | ||
| "*.yml": "azure-pipelines" | ||
| }, | ||
| // ms-dotnettools.csharp settings |
There was a problem hiding this comment.
This is all duplicated with the .vscode/settings.json -- is there a way to avoid the duplication? And what is using this file?
There was a problem hiding this comment.
unfortunately there does not seem to be a way to do this today. The settings in this file are used by codespaces
| "*.vsixmanifest": "xml", | ||
| "*.vstemplate": "xml", | ||
| "*.xlf": "xml", | ||
| "*.yml": "azure-pipelines" |
There was a problem hiding this comment.
Do we have any yaml for other things than the build pipelines? I had restricted it to eng not wanting that to accidentally apply elsewhere.
There was a problem hiding this comment.
I checked, we do not
5 participants
