Skip to content

Move FunctionIdOptions to EditorFeatures#59166

Merged
tmat merged 1 commit into
dotnet:mainfrom
tmat:FunctionIdOptions
Feb 3, 2022
Merged

Move FunctionIdOptions to EditorFeatures#59166
tmat merged 1 commit into
dotnet:mainfrom
tmat:FunctionIdOptions

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Jan 30, 2022 •
edited
Loading

Remove PerformanceFunctionIdOptionsProvider - IOptionProvider is only needed for solution options.

@tmat tmat requested a review from a team as a code owner January 30, 2022 21:07
@ghost ghost added the Area-IDE label Jan 30, 2022
@tmat
Copy link
Copy Markdown
Member Author

tmat commented Jan 31, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jan 31, 2022

Azure Pipelines successfully started running 4 pipeline(s).

@tmat tmat force-pushed the FunctionIdOptions branch from 39321b3 to ae6eca6 Compare February 2, 2022 19:18
@JoeRobich
Copy link
Copy Markdown
Member

JoeRobich commented Feb 2, 2022 •
edited
Loading

Why is EditorFeatures the right layer for this? Are Solution options only used in VS?

@runfoapp runfoapp Bot mentioned this pull request Feb 2, 2022
Closed
@tmat
Copy link
Copy Markdown
Member Author

tmat commented Feb 2, 2022 •
edited
Loading

@JoeRobich Global options are client options (i.e. not available in OOP). Workspaces and Features are server (OOP) components. EditorFeatures and VS are client components. EditorFeastures is x-plat, VS is not. Makes sense?

@JoeRobich
Copy link
Copy Markdown
Member

JoeRobich commented Feb 2, 2022

@JoeRobich Global options are client options (i.e. not available in OOP). Workspaces and Features are server (OOP) components. EditorFeatures and VS are client components. EditorFeastures is x-plat, VS is not. Makes sense?

Thanks for that description of our layering. I feel like little gaps get filed in the more I learn.

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Feb 2, 2022

@JoeRobich No problem. It's been a bit fuzzy historically, but with the latest refactorings the separation is hopefully more clear now.

@tmat tmat enabled auto-merge (squash) February 3, 2022 00:20
@tmat tmat merged commit f413eb6 into dotnet:main Feb 3, 2022
@ghost ghost added this to the Next milestone Feb 3, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P1 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees

No one assigned

Labels

Area-IDE

Projects

None yet

Milestone

17.2.P1

Development

Successfully merging this pull request may close these issues.

3 participants

@tmat @JoeRobich @RikkiGibson