Skip to content

Add FindUsagesOptions and thread option getter through FAR services#59306

Merged
tmat merged 2 commits into
dotnet:mainfrom
tmat:FAROptions
Feb 7, 2022
Merged

Add FindUsagesOptions and thread option getter through FAR services#59306
tmat merged 2 commits into
dotnet:mainfrom
tmat:FAROptions

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Feb 5, 2022

@tmat tmat requested review from a team as code owners February 5, 2022 01:22
@ghost ghost added the Area-IDE label Feb 5, 2022
@tmat tmat changed the title Far options Add FindUsagesOptions and thread option getter through FAR services Feb 5, 2022
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

not sure how i feel about thsi change. it doesn't feel intuitive to me (yet) that options are part of a context object (which is intended to push results into as the find progresses).

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Feb 5, 2022

not sure how i feel about thsi change. it doesn't feel intuitive to me (yet) that options are part of a context object (which is intended to push results into as the find progresses).

We need to be able to call back to the in-proc impl to fetch the options lazily because we do not know upfront what languages are we gonna find the references in and we do not want to pre-fetch the options for all languages.

Context is created at the entry point of the feature on the client and thus has access to the client options.

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

I want to be on the same page here. What option does findrefs need? I'm surprised you hear that it would depend on anything lang specific.

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Feb 5, 2022

Classification options. The SourceReferenceItem passed to OnReferenceFoundAsync are classified using the language's classification options.

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Feb 5, 2022

Interesting: SerializableDocumentSpan does not serialize Properties of DocumentSpan that may contain classification spans.

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

Classification options. The SourceReferenceItem passed to OnReferenceFoundAsync are classified using the language's classification options.

Bleagh... there are times when i wish things were not lang-specific options.

@tmat tmat enabled auto-merge (squash) February 7, 2022 23:15
@tmat tmat merged commit 68353c4 into dotnet:main Feb 7, 2022
@ghost ghost added this to the Next milestone Feb 7, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants