Assert diagnostics pass correct number of arguments

[Youssef1313]

Related to #59418

[davidwengier]

I appreciate the thought, but this would not have helped uncover the linked issue, so I'm not sure this has much value from an ENC standpoint. I guess someone from @dotnet/roslyn-compiler might have a different opinion?

[Youssef1313]

@davidwengier I'm surprised the assertion didn't fail for ENC0088. I'll try to take a look and understand why.

[davidwengier]

@davidwengier I'm surprised the assertion didn't fail for ENC0088. I'll try to take a look and understand why.

That diagnostic is only reported when an unknown error happens. We don't have tests for unknown errors, because if we knew what the error was we'd fix it :)

[Youssef1313]

I thought this test is "faking" the unexpected exception via the faultInjector parameter:

roslyn/src/EditorFeatures/CSharpTest/EditAndContinue/ActiveStatementTests.cs

Lines 11228 to 11230 in 02a5659

	var expectedDiagnostic = outOfMemory ?
	Diagnostic(RudeEditKind.MemberBodyTooBig, "public static void G()", FeaturesResources.method) :
	Diagnostic(RudeEditKind.MemberBodyInternalError, "public static void G()", FeaturesResources.method);

[davidwengier]

Well now I'm confused.. if we had a test for that scenario, then why is it passing at all, given the bug?

I will have to dig in more

[davidwengier]

@Youssef1313 I updated #59443 to validate all EnC diagnostics.

Do you think there is still value in this PR for general compiler scenarios?

[Youssef1313]

@davidwengier I think it will be beneficial, not only for compiler messages, but also IDExxxx.

I'll have to make sure this actually fails for both scenarios.

[Youssef1313]

I think it will be beneficial, not only for compiler messages, but also IDExxxx.

Compiler part was already done in #60925. This PR is now about analyzers.

[CyrusNajmabadi]

approve

[Youssef1313]

Please wait on merging this. I think this won't detect everything because of the early return for _messageArgs.Length == 0. Fixed in cfd414c. Waiting on CI to see if there are additional failures.