Inline Diagnostics Multi-Line Errors#60013
Merged
Merged
Conversation
ghost
added
the
ryzngard
approved these changes
Mar 7, 2022
| /// <summary> | ||
| /// Get the spans located on each line so that it can only display the first one that appears on the line | ||
| /// </summary> | ||
| private void AddSpansOnEachLine(NormalizedSnapshotSpanCollection changedSpanCollection, |
Contributor
There was a problem hiding this comment.
Is this change just moving the method? Can you undo if that's the only change to this file?
Member
Author
There was a problem hiding this comment.
yeah I just moved the method since it should've been below the calling method. Do I need to create a separate PR for that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: AB#1486913
I made an earlier PR (#58398) to look at the ending span location to draw the tag in the correct location. I did not also edit what creates the mapping of line number to tag to use the span end, which is why we were seeing multiple tags on the same line.