Rework our Helix Process#76703
Merged
jaredpar merged 4 commits intodotnet:mainfrom Jan 11, 2025
Merged
Conversation
ghost
added
Area-Infrastructure
untriaged
jaredpar
force-pushed
the
helix7
branch
7 times, most recently
from
eef88e7 to
ac11040
Compare
Closed
jaredpar
force-pushed
the
helix7
branch
4 times, most recently
from
3476088 to
17e1c94
Compare
The goal of this change is to cleanly separate out the two behaviors of RunTests: locally executing tests and scheduling jobs on Helix. This is a pre-cursor to actually moving these behaviors into separate projects entirely.
arunchndr
approved these changes
Jan 10, 2025
dibarbet
approved these changes
Jan 10, 2025
| builder.AppendLine($""" | ||
| <HelixWorkItem Include="{helixWorkItem.DisplayName}"> | ||
| <PayloadDirectory>{workItemPayloadDir}</PayloadDirectory> | ||
| <Command>{commandPrefix}{commandFileName}</Command> |
RikkiGibson
reviewed
Jan 10, 2025
Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jan 14, 2025
* upstream/main: (368 commits) Cleanup tests Add test Add test Add test Fix issue parsing regex category Properly simplify pattern when converting to pattern matching update publishdata after VS 17.13 snap Simplify Docs Do not lift type parameters in extract method declared within the selected region Fix ExtractMethod in VB elseif blocks Rework our Helix Process (dotnet#76703) Stash and restore original culture in CultureNormalizer (dotnet#76713) PR comments Adding checks for mutable structs. Add additional tests for string escape sequences CodeGenerator.EmitStackAlloc - Avoid capturing blob array (dotnet#76660) Update comments and exception type for LSP stdio configuration based on review feedback Fix race generating Microsoft.Managed.Core.CurrentVersions.targets (dotnet#76701) Update FileDownloader.cs ...
This was referenced Jan 14, 2025
This was referenced Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggest reviewing this commit by commit:
The most impactful change is the slimming down of work item payloads. They moved down in size from 1.8GB to ~100MB. That moved the time to download + unpack on Windows from one minute to one second. This action occurs on every work item so the time savings is multiplied by the number of work items in every job (a lot)