Change DocumentAnalysisExecutor to use ValueTask#80293
Merged
ToddGrun merged 1 commit intodotnet:mainfrom Sep 16, 2025
Merged
Conversation
In draft mode, until I get speedometer numbers to make sure this has the desired effect.
ToddGrun
changed the title
CyrusNajmabadi
approved these changes
Sep 16, 2025
This was referenced Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocumentAnalysisExecutor has several Task returning methods that are showing up as decent allocators in the speedometer profile.
Verified in the below test insertion that switching over to ValueTask removes those allocations. The CPU profile of the changed methods looks unchanged.
Test insertion pipeline run: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=12391841&view=results