Skip to content

Backport publish data to 16.11#80335

Merged
333fred merged 6 commits intodotnet:release/dev16.11-vs-depsfrom
dibarbet:backport_publish_data_16_11
Sep 19, 2025
Merged

Backport publish data to 16.11#80335
333fred merged 6 commits intodotnet:release/dev16.11-vs-depsfrom
dibarbet:backport_publish_data_16_11

Conversation

@dibarbet
Copy link
Copy Markdown
Member

@dibarbet dibarbet commented Sep 17, 2025 •
edited
Loading

@dibarbet dibarbet requested a review from a team as a code owner September 17, 2025 18:35
dibarbet
dibarbet commented Sep 18, 2025
View reviewed changes
Comment thread azure-pipelines-official.yml
feedSource: https://dnceng.pkgs.visualstudio.com/_packaging/MicroBuildToolset/nuget/v3/index.json
condition: and(succeeded(), in(variables['SignType'], 'test', 'real'))
# Set ConnectedPMEServiceName if the build is a CI build, otherwise it is not needed
${{ if eq(variables['Build.Reason'], 'IndividualCI') }}:
Copy link
Copy Markdown
Member Author

@dibarbet dibarbet Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rolled #80090 into this one since they're both hitting the same test issues anyway

@dibarbet
Copy link
Copy Markdown
Member Author

dibarbet commented Sep 18, 2025 •
edited
Loading

official build - https://dnceng.visualstudio.com/internal/_build/results?buildId=2796053&view=results
got farther than what is currently in release/dev16.11-vs-deps. Hit an insertion issue (though appears to be completely unrelated to my changes)

##[error] System.InvalidOperationException: Sequence contains more than one element
   at System.Linq.Enumerable.SingleOrDefault[TSource](IEnumerable`1 source)
   at Roslyn.Insertion.CoreXT.GetVersionAttributeOrElementInPropsFile(XDocument document, PackageInfo packageInfo) in /_/src/RoslynInsertionTool/RoslynInsertionTool/CoreXT.cs:line 189
   at Roslyn.Insertion.CoreXT.GetVersionStringInPropsFile(PackageInfo packageInfo) in /_/src/RoslynInsertionTool/RoslynInsertionTool/CoreXT.cs:line 172
   at Roslyn.Insertion.CoreXT.TryGetPackageVersion(PackageInfo packageInfo, NuGetVersion& version) in /_/src/RoslynInsertionTool/RoslynInsertionTool/CoreXT.cs:line 263
   at Roslyn.Insertion.RoslynInsertionTool.UpdatePackages(BuildVersion buildVersion, CoreXT coreXT, String packagesDir, ImmutableArray`1 packagesToBeIgnored, Boolean skipPackageVersionValidation, CancellationToken cancellationToken) in /_/src/RoslynInsertionTool/RoslynInsertionTool/RoslynInsertionTool.Packages.cs:line 57
   at Roslyn.Insertion.RoslynInsertionTool.<PerformInsertionAsync>d__13.MoveNext() in /_/src/RoslynInsertionTool/RoslynInsertionTool/RoslynInsertionTool.cs:line 190

@dibarbet dibarbet mentioned this pull request Sep 18, 2025
Closed
@dibarbet dibarbet force-pushed the backport_publish_data_16_11 branch from 1f99049 to b5c692b Compare September 18, 2025 20:28
@dibarbet
Copy link
Copy Markdown
Member Author

dibarbet commented Sep 18, 2025

updated build - https://dnceng.visualstudio.com/internal/_build/results?buildId=2796646&view=results

@dibarbet
Copy link
Copy Markdown
Member Author

dibarbet commented Sep 18, 2025

official build passed

dibarbet
dibarbet commented Sep 18, 2025
View reviewed changes
Comment thread eng/config/PublishData.json
"vsMajorVersion": 16
},
"features/unitTesting": {
"release/dev16.11-vs-deps": {
Copy link
Copy Markdown
Member Author

@dibarbet dibarbet Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branch needs this now that it isn't pulling from main.

@333fred 333fred merged commit ed3c498 into dotnet:release/dev16.11-vs-deps Sep 19, 2025
11 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

@333fred 333fred 333fred approved these changes

@akhera99 akhera99 akhera99 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dibarbet @JoeRobich @333fred @akhera99