Skip to content

JIT: SVE Cleanup - In the importer, always ConvertToMask on SVE APIs that require a mask. #104836

@TIHan

Description

@TIHan

Discussion: #104704 (comment)

Code:

        if (!varTypeIsMask(op))
        {
            op = gtNewSimdCvtVectorToMaskNode(TYP_MASK, op, simdBaseJitType, simdSize);
        }

The idea is that we shouldn't have to check for varTypeIsMask(op); meaning at this point, op should be returning TYP_SIMD. Therefore, we should always add a ConvertToMask node:

        assert(varTypeIsSIMD(op));
        op = gtNewSimdCvtVectorToMaskNode(TYP_MASK, op, simdBaseJitType, simdSize);

Metadata

Metadata

Assignees

Labels

Priority:3Work that is nice to havearch-arm64area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIarm-sveWork related to arm64 SVE/SVE2 supportin-prThere is an active PR which will close this issue when it is merged

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions