-
Notifications
You must be signed in to change notification settings - Fork 5.4k
CodeGen: Clarify the naming and usage of consumeReg methods #12179
Copy link
Copy link
Open
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMICLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIdocumentationDocumentation bug or enhancement, does not impact product or test codeDocumentation bug or enhancement, does not impact product or test codehelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributors
Milestone
Description
Metadata
Metadata
Assignees
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMICLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIdocumentationDocumentation bug or enhancement, does not impact product or test codeDocumentation bug or enhancement, does not impact product or test codehelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributors
Type
Fields
Give feedbackNo fields configured for issues without a type.
The naming and usage of the various consumeReg methods is not clearly articulated anywhere. Their usage should probably be documented in codegen.h where they are declared.
This came up in the discussion of dotnet/coreclr#22944
category:implementation
theme:jit-coding-style
skill-level:beginner
cost:medium