[API Proposal]: Add Registered ID attribute to SubjectAlternativeNameBuilder

[Harmyder]

Background and motivation

I'm working on MDM solution and trying to move all old code to .NET. Here I'm stuck with SAN because SubjectAlternativeNameBuilder doesn't support Registered ID.

API Proposal

namespace System.Security.Cryptography.X509Certificates;

public sealed class SubjectAlternativeNameBuilder
{
	public void AddRegisteredID(string registeredId)
	{
		AddGeneralName(new GeneralNameAsn
		{
			RegisteredId= registeredId
		});
	}

API Usage

var san = new SubjectAlternativeNameBuilder();
san.AddRegisteredID(value);

Alternative Designs

No response

Risks

Should be easy because GeneralNameAsn already has support for this attribute.

[dotnet-policy-service]

Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security
See info in area-owners.md if you want to be subscribed.

[MihuBot]

I'm a bot. Here is a possible related and/or duplicate issue (I may be wrong):

• [API Proposal]: Add Missing methods to SubjectAlternativeNameBuilder Ex: AddDirectoryName #112069

[vcsjones]

I think the exact name would probably be more something like

public void AddRegisteredId(string registeredIdOid);

@bartonjs but seems reasonable to me?

[bartonjs]

I'm having trouble deciding what I like of

public void AddRegisteredId(string registeredIdOid);
public void AddRegisteredId(string registeredOid);
public void AddRegisteredId(string registeredId);

but the method name seems fine. I've gone ahead and marked it ready for review.

I can't think of any reason why we'd really have need to accept the OID value in a form other than string (so no overloads seem necessary)

[bartonjs]

Video

• We discussed the various alternatives for the parameter name, and landed on registeredId.
• We fixed the casing on "ID" to "Id"

namespace System.Security.Cryptography.X509Certificates;

public sealed class SubjectAlternativeNameBuilder
{
    public void AddRegisteredId(string registeredId);
}