Non-Windows builds are broken due to recent change in Microsoft.VisualBasic.builds file

[joperezr]

After dotnet/corefx#6572 got merged, non-Windows builds started hitting the following error:

vbc : error BC31030: Project-level conditional compilation constant 'CONFIG= ^^ ^^ /"Windows_NT_Debug/"' is not valid: Syntax error in conditional compilation expression. [/Users/dotnet-bot/j/workspace/dotnet_corefx/outerloop_osx_debug/src/Microsoft.VisualBasic/src/Microsoft.VisualBasic.vbproj]

I believe that root cause is this change which for some reason started building the Vb project in non-Windows as well.

@sokket could you please take a look?

[joperezr]

There are actually other errors that started happening after the same merge, they are all in System.Net.Sockets.csproj. Here are a few of the lines that I'm seeing:

/Users/joperezr/Desktop/git/corefx/src/Common/src/System/Net/SocketProtocolSupportPal.Unix.cs(6,18): error CS0234: The type or namespace name 'Internals' does not exist in the namespace 'System.Net' (are you missing an assembly reference?) [/Users/joperezr/Desktop/git/corefx/src/System.Net.Sockets/src/System.Net.Sockets.csproj]
/Users/joperezr/Desktop/git/corefx/src/Common/src/Interop/Unix/System.Native/Interop.Socket.cs(7,18): error CS0234: The type or namespace name 'Internals' does not exist in the namespace 'System.Net' (are you missing an assembly reference?) [/Users/joperezr/Desktop/git/corefx/src/System.Net.Sockets/src/System.Net.Sockets.csproj]
System/Net/Sockets/BaseOverlappedAsyncResult.Unix.cs(20,42): error CS0436: The type 'Socket' in '/Users/joperezr/Desktop/git/corefx/src/System.Net.Sockets/src/System/Net/Sockets/Socket.Unix.cs' conflicts with the imported type 'Socket' in 'System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'. Using the type defined in '/Users/joperezr/Desktop/git/corefx/src/System.Net.Sockets/src/System/Net/Sockets/Socket.Unix.cs'. [/Users/joperezr/Desktop/git/corefx/src/System.Net.Sockets/src/System.Net.Sockets.csproj]
System/Net/Sockets/ConnectOverlappedAsyncResult.Unix.cs(22,34): error CS0115: 'ConnectOverlappedAsyncResult.PostCompletion(int)': no suitable method found to override [/Users/joperezr/Desktop/git/corefx/src/System.Net.Sockets/src/System.Net.Sockets.csproj]
...

[jonmill]

Looking now

[jonmill]

The Visual Basic fix is super quick; VB does not support building on non-Windows platforms so I can add Condition="'$(OS)'=='Windows_NT'" to the builds files and that should solve this one particular one-off. Looking into Sockets now

[jonmill]

Fixed!