Desktop: System.Diagnostics.Tests.ProcessStartInfoTests.StartInfo_TextFile_ShellExecute fails occasionally on NETFX

[KristinXie1]

Failed test: System.Diagnostics.Tests.ProcessStartInfoTests.StartInfo_TextFile_ShellExecute (from System.Diagnostics.Process.Tests)

Detail: https://ci.dot.net/job/dotnet_corefx/job/master/job/outerloop_netfx_windows_nt_debug/67/testReport/System.Diagnostics.Tests/ProcessStartInfoTests/StartInfo_TextFile_ShellExecute/

Configuration: outerloop_netfx_windows_nt_debug

MESSAGE:

System.NullReferenceException : Object reference not set to an instance of an object.

STACK TRACE:

at System.Diagnostics.Tests.ProcessStartInfoTests.StartInfo_TextFile_ShellExecute() 
in D:\j\workspace\outerloop_net---903ddde6\src\System.Diagnostics.Process\tests\ProcessStartInfoTests.cs:line 1013

[v-haren]

failed again here: https://ci.dot.net/job/dotnet_corefx/job/master/job/outerloop_netcoreapp_windows_nt_debug/56/testReport/System.Diagnostics.Tests/ProcessStartInfoTests/StartInfo_TextFile_ShellExecute/

[stephentoub]

This has been failing a lot, on both netfx and netcoreapp.

[danmoseley]

I can't see the issue, I'll disable it. Hopefully you can figure this ot Jeremy as it's the only shell execute test we have.

[danmoseley]

Leaving this in 2.0 as it's important we re-enable this test for 2.0 as its' the only coverage of shell execute.

[danmoseley]

@JeremyKuhne can you figure this out? I'm not comfortable shipping 2.0 with this test disabled, both because we might miss a regression, and because we'll be servicing 2.0 for a while.

[JeremyKuhne]

@danmosemsft I can look. We do have the test that uses shell execute with the app name. I presume there is something with the machines that doesn't have the file association in a known state. Fair warning- this will probably take a while to investigate.

[JeremyKuhne]

Note that we need to update the UAP exclusion in any case. They shouldn't be skipped for UAP, just the title verification should be modified.

[danmoseley]

@JeremyKuhne as it's only a sporadic failure, you could reenable for outerloop with some dumping of appropriate registry keys, then leave it until it fails again.

[JeremyKuhne]

@danmosemsft This test was already OuterLoop

[danmoseley]

Ah you're right.

[danmoseley]

@JeremyKuhne you caught a fish - on both Windows 8 jenkins runs

     System.Diagnostics.Tests.ProcessStartInfoTests.StartInfo_TextFile_ShellExecute [FAIL]
  downloaded dumpling.py
        Could not start C:\Users\dotnet-bot\AppData\Local\Temp\ProcessStartInfoTests_o1533hky.bcw\StartInfo_TextFile_ShellExecute_1010_ffb06b13.txt UseShellExecute=True
        Association details for '.txt'
        ------------------------------
        Open command: C:\Windows\system32\OpenWith.exe "%1"
        ProgID: Didn't get expected HRESULT (1) when getting char count. HRESULT was 0x80070057
        
        Expected: True
        Actual:   False
        Stack Trace:
           D:\j\workspace\outerloop_net---7a39cc82\src\System.Diagnostics.Process\tests\ProcessStartInfoTests.cs(1010,0): at System.Diagnostics.Tests.ProcessStartInfoTests.StartInfo_TextFile_ShellExecute()
  total elapsed time 0:00:00.370000

https://ci.dot.net/job/dotnet_corefx/job/master/job/outerloop_netcoreapp_windows_nt_release/lastCompletedBuild/consoleText

I believe these machines are actually Server 2012 R2 .. from the console output
OS=Microsoft Windows 6.3.9600 OSVer=Microsoft Windows NT 6.2.9200.0 OSArch=X64 Arch=X64 Framework=.NET Core 4.6.00001.0

OSVer/Environment.OSVersion comes from GetVersionExW
OS comes from RtlGetVersion, which doesn't "lie" -> so I think this is Windows 8.1 or Server 2012 R2 and I believe we use the latter.

[danmoseley]

Incidentally if i change the code to look for ".foo" instead of ".txt" (on Win10) I don't get E_INVALIDARG like that.

Association details for '.foo'
        ------------------------------
        Open command: C:\WINDOWS\system32\OpenWith.exe "%1"
        ProgID: Unknown

Guess: it needs the "Desktop Experience" feature installed to work. If so, we could just make E_INVALIDARG here a "pass".

[KristinXie1]

Failed with Cannot start ..., detail: https://ci.dot.net/job/dotnet_corefx/job/master/job/outerloop_netfx_windows_nt_debug/90/testReport/System.Diagnostics.Tests/ProcessStartInfoTests/StartInfo_TextFile_ShellExecute/

[v-haren]

failed again here: https://ci.dot.net/job/dotnet_corefx/job/master/job/outerloop_netcoreapp_windows_nt_debug/80/testReport/System.Diagnostics.Tests/ProcessStartInfoTests/StartInfo_TextFile_ShellExecute/